aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Phillips <dbphillipsnz@gmail.com>2016-07-27 12:45:49 +1200
committerDavid Phillips <dbphillipsnz@gmail.com>2016-07-27 12:45:49 +1200
commit655de78ea46a22add7955c302015c8c3120531bb (patch)
tree396503b120090c5e471597c1c30d9131ac405c2d
parentbe8209cdf61f69b1117873163475aee11a7bc582 (diff)
downloadbrightnessd-master.tar.xz
Check for error on fifo open failure, remove stale commentHEADmaster
-rw-r--r--brightnessd.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/brightnessd.c b/brightnessd.c
index 68aad05..af5a16d 100644
--- a/brightnessd.c
+++ b/brightnessd.c
@@ -74,7 +74,7 @@ int drop_priv()
int get_now(FILE *f)
{
- char buffer[BRIGHT_BUFFER_SIZE]; /* FIXME: magic constant is icky */
+ char buffer[BRIGHT_BUFFER_SIZE];
/* FIXME: check return value for error */
fgets(buffer, sizeof(buffer), f);
@@ -123,8 +123,12 @@ int main(int argc, char **argv)
now = get_now(f);
target = now;
- /* FIXME : check return val */
fifo = open(FIFO_PATH, O_RDWR);
+ if (fifo == -1) {
+ perror("open");
+ fclose(f);
+ return 1;
+ }
fds.fd = fifo;
fds.events = POLLIN;