From 655de78ea46a22add7955c302015c8c3120531bb Mon Sep 17 00:00:00 2001 From: David Phillips Date: Wed, 27 Jul 2016 12:45:49 +1200 Subject: Check for error on fifo open failure, remove stale comment --- brightnessd.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/brightnessd.c b/brightnessd.c index 68aad05..af5a16d 100644 --- a/brightnessd.c +++ b/brightnessd.c @@ -74,7 +74,7 @@ int drop_priv() int get_now(FILE *f) { - char buffer[BRIGHT_BUFFER_SIZE]; /* FIXME: magic constant is icky */ + char buffer[BRIGHT_BUFFER_SIZE]; /* FIXME: check return value for error */ fgets(buffer, sizeof(buffer), f); @@ -123,8 +123,12 @@ int main(int argc, char **argv) now = get_now(f); target = now; - /* FIXME : check return val */ fifo = open(FIFO_PATH, O_RDWR); + if (fifo == -1) { + perror("open"); + fclose(f); + return 1; + } fds.fd = fifo; fds.events = POLLIN; -- cgit v1.1