diff options
| author | David Phillips <david@yeah.nah.nz> | 2021-05-16 21:19:29 +1200 |
|---|---|---|
| committer | David Phillips <david@yeah.nah.nz> | 2021-05-16 21:24:14 +1200 |
| commit | 1a0eda1f6876a1a7482115630b2dd9014efd2ec1 (patch) | |
| tree | 6debe93e0aa77ff7f6f3febd8e8f7a104cfb3c64 | |
| parent | 4c0e0e4711a30923603b3bcd8cdf297c04aecef9 (diff) | |
| download | cds9k-1a0eda1f6876a1a7482115630b2dd9014efd2ec1.tar.xz | |
led: dev_err on regmap read failure
| -rw-r--r-- | cds9k-led.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/cds9k-led.c b/cds9k-led.c index adcb18b..9e211f9 100644 --- a/cds9k-led.c +++ b/cds9k-led.c @@ -15,6 +15,7 @@ struct cds9k_led { struct led_classdev cdev; struct regmap *regmap; + struct device *dev; u32 base; }; @@ -51,9 +52,10 @@ enum led_brightness cds9k_led_brightness_get(struct led_classdev *led_cdev) struct cds9k_led *led = container_of(led_cdev, struct cds9k_led, cdev); ret = regmap_read(led->regmap, led->base + LED_REG_VALUE, &brightness); - /* FIXME log something */ - if (!ret) + if (ret) { + dev_err(led->dev, "Failed to read LED brightness"); return LED_OFF; + } if (brightness > LED_FULL) brightness = LED_FULL; @@ -83,6 +85,7 @@ static int cds9k_led_probe(struct platform_device *pdev) if (!led->regmap) return -ENODEV; + led->dev = &pdev->dev; led->cdev.name = of_get_property(np, "label", NULL) ? : np->name; led->cdev.default_trigger = of_get_property(np, "linux,default-trigger", NULL); led->cdev.brightness_set = cds9k_led_brightness_set; |