aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Phillips <david@yeah.nah.nz>2021-05-22 17:35:02 +1200
committerDavid Phillips <david@yeah.nah.nz>2021-05-22 17:35:02 +1200
commit0d185a49c8404ae388fb2c8cd7e1612680db4d89 (patch)
treecc64794c657895bc031e2771a9b6d9638d3c49d3
parentcb1873c3270b9f0891a9bc0faebb45b23f3cb37b (diff)
downloadcds9k-master.tar.xz
Ensure driver functions and data are staticHEADmaster
-rw-r--r--cds9k-fan.c10
-rw-r--r--cds9k-led.c12
-rw-r--r--cds9k-reset.c2
3 files changed, 14 insertions, 10 deletions
diff --git a/cds9k-fan.c b/cds9k-fan.c
index 8a58aa0..fa28e30 100644
--- a/cds9k-fan.c
+++ b/cds9k-fan.c
@@ -22,7 +22,9 @@ static unsigned int cds9k_rpm_to_pwm(long rpm)
return max_pwm * rpm / max_rpm;
}
-static umode_t cds9k_fan_is_visible(const void *fan, enum hwmon_sensor_types type, u32 attr, int channel)
+static umode_t cds9k_fan_is_visible(const void *fan,
+ enum hwmon_sensor_types type, u32 attr,
+ int channel)
{
if (channel != 0)
return 0;
@@ -36,7 +38,8 @@ static umode_t cds9k_fan_is_visible(const void *fan, enum hwmon_sensor_types typ
return 0;
}
-static int cds9k_fan_read(struct device *dev, enum hwmon_sensor_types type, u32 attr, int channel, long *value)
+static int cds9k_fan_read(struct device *dev, enum hwmon_sensor_types type,
+ u32 attr, int channel, long *value)
{
int ret;
struct cds9k_fan *fan = dev_get_drvdata(dev);
@@ -64,7 +67,8 @@ static int cds9k_fan_read(struct device *dev, enum hwmon_sensor_types type, u32
return 0;
}
-static int cds9k_fan_write(struct device *dev, enum hwmon_sensor_types type, u32 attr, int channel, long value)
+static int cds9k_fan_write(struct device *dev, enum hwmon_sensor_types type,
+ u32 attr, int channel, long value)
{
unsigned int target_pwm;
struct cds9k_fan *fan = dev_get_drvdata(dev);
diff --git a/cds9k-led.c b/cds9k-led.c
index 55f4ce7..3de9e98 100644
--- a/cds9k-led.c
+++ b/cds9k-led.c
@@ -19,9 +19,9 @@ struct cds9k_led {
u32 base;
};
-int cds9k_led_blink_set(struct led_classdev *led_cdev,
- unsigned long *delay_on,
- unsigned long *delay_off)
+static int cds9k_led_blink_set(struct led_classdev *led_cdev,
+ unsigned long *delay_on,
+ unsigned long *delay_off)
{
struct cds9k_led *led = container_of(led_cdev, struct cds9k_led, cdev);
unsigned long blink_value;
@@ -35,8 +35,8 @@ int cds9k_led_blink_set(struct led_classdev *led_cdev,
return regmap_write(led->regmap, led->base + LED_REG_PERIOD, blink_value);
}
-void cds9k_led_brightness_set(struct led_classdev *led_cdev,
- enum led_brightness brightness)
+static void cds9k_led_brightness_set(struct led_classdev *led_cdev,
+ enum led_brightness brightness)
{
unsigned long blink_off = 0;
struct cds9k_led *led = container_of(led_cdev, struct cds9k_led, cdev);
@@ -45,7 +45,7 @@ void cds9k_led_brightness_set(struct led_classdev *led_cdev,
cds9k_led_blink_set(led_cdev, &blink_off, &blink_off);
}
-enum led_brightness cds9k_led_brightness_get(struct led_classdev *led_cdev)
+static enum led_brightness cds9k_led_brightness_get(struct led_classdev *led_cdev)
{
int ret;
unsigned int brightness;
diff --git a/cds9k-reset.c b/cds9k-reset.c
index 5750376..de6b292 100644
--- a/cds9k-reset.c
+++ b/cds9k-reset.c
@@ -35,7 +35,7 @@ static int cds9k_reset_xlate(struct reset_controller_dev *rcdev,
return 0;
}
-const struct reset_control_ops cds9k_reset_ops = {
+static const struct reset_control_ops cds9k_reset_ops = {
.reset = cds9k_reset_reset,
};